potiuk opened a new pull request, #26419:
URL: https://github.com/apache/airflow/pull/26419

   The SVG images embedded via <img> tag are not the best when it comes to 
accessibility (even if we have "alt" descriptions). The SVG images are 
pre-rendered before displaying in this case and their content is not readable 
for visualy impaired people.
   
   We could try to embed the .svg images instead, which makes them better 
readable and accessible, but this is a bit complex and would make the 
BREEZE.rst huge. We could also embed it via raw html, but GitHub does not allow 
this.
   
   Another technique which is recommended is to turn the images to raw version 
of the .svg files which (when image is clicked) render nicely in the browser 
but the browser actually turns the SVG source as part of DOM, making the image 
content accessible to screen readers.
   
   Another positive aspect of this change is that you can actually copy&paste 
the text of the images when you click them.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to