mik-laj edited a comment on issue #5450: [AIRFLOW-4775] - fix incorrect parameter order in GceHook URL: https://github.com/apache/airflow/pull/5450#issuecomment-504945875 In my opinion, this PR is not correct. We have two static methods: * _check_zone_operation_status method accepts 5 arguments * _check_global_operation_status method accepts 4 arguments This change applies to the second case - `_check_global_operation_status`, but 5 arguments are passed. My fixup commit is available: ``` curl https://termbin.com/0mun | git am ``` I think that we should not mock the private methods of the class we are testing. This causes us to have the wrong impression that something is tested when it really is not. Here is an example of how I would like these tests to look: https://github.com/apache/airflow/blob/master/tests/contrib/hooks/test_gcp_cloud_build_hook.py
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
