potiuk commented on PR #26166: URL: https://github.com/apache/airflow/pull/26166#issuecomment-1250385901
> @ephraimbuddy , Is it too expensive if just to fix this problem? I think what @ephraimbuddy suggest is to fix it properly - i.e. reuse the code that is used in scheduler. We are not only focusing on fixing the problems, but also to make sure that they can be maintained in the future and avoid a lot of duplication in the logic. Seems that attempting to fix the issue by doing it in the same way as in the scheduler, fits that criteria. Also speaking about maintainability, this code lacks any tests testing the behaviour (failing before/succeeding after the change) which makes it super-difficult to refactor the code later in case we decide to improve this part. So I suggest to do both here: * take a look at how scheaduler deals with it (potentially reusing code from it - maybe even extracting some common code) * write a test to cover this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
