dstandish commented on code in PR #25787:
URL: https://github.com/apache/airflow/pull/25787#discussion_r975546116
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -301,36 +301,39 @@ def create_custom_object(
):
"""
Creates custom resource definition object in Kubernetes
-
:param group: api group
:param version: api version
:param plural: api plural
:param body: crd object definition
:param namespace: kubernetes namespace
"""
api = client.CustomObjectsApi(self.api_client)
+
if namespace is None:
namespace = self.get_namespace()
- if isinstance(body, str):
- body_dict = _load_body_to_dict(body)
- else:
- body_dict = body
- try:
- api.delete_namespaced_custom_object(
- group=group,
- version=version,
- namespace=namespace,
- plural=plural,
- name=body_dict["metadata"]["name"],
- )
- self.log.warning("Deleted SparkApplication with the same name.")
- except client.rest.ApiException:
- self.log.info("SparkApp %s not found.",
body_dict['metadata']['name'])
+
+ body_dict: dict = _load_body_to_dict(body) if isinstance(body, str)
else body
+
+ # Attribute "name" is not mandatory if "generateName" is used instead
+ if "name" in body_dict["metadata"]:
Review Comment:
can you clarify what you're doing here with this change?
you say
> Attribute "name" is not mandatory if "generateName" is used instead
which suggests, you can still delete the object without `name` as long as
`generateName` is present.
but, with your change, if `name` is not present, it appears you won't
attempt to delete the object at all!
is it not required to delete the object here? am i missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
