ashb opened a new pull request, #26553:
URL: https://github.com/apache/airflow/pull/26553

   We can simplify the build/pre-commit process a bit. It turns out that 
`license_files` is actually a list of glob-patterns, not just literal files, so 
we can remove the pre-commit step to generate this list and keep it ordered.
   
   Tests to make sure it still gets included:
   
   ```
   $unzip -l dist/apache_airflow-2.5.0.dev0-py3-none-any.whl | grep 
apache_airflow-2.5.0.dev0.dist-info
       13661  2022-09-21 11:00   apache_airflow-2.5.0.dev0.dist-info/LICENSE
        1131  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-bootstrap.txt
         984  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-bootstrap3-typeahead.txt
        1475  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-d3-shape.txt
        1079  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-d3-tip.txt
        1475  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-d3js.txt
        1062  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-dagre-d3.txt
        1076  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-datatables.txt
        1081  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-elasticmock.txt
        1096  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-eonasdan-bootstrap-datetimepicker.txt
        1301  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-flask-kerberos.txt
       11349  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-hue.txt
       11357  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-jqclock.txt
        1605  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-jquery.txt
        1077  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-moment-strftime.txt
        1075  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-moment.txt
        1096  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSE-normalize.txt
      115987  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/LICENSES-ui.txt
      120239  2022-09-21 11:00   apache_airflow-2.5.0.dev0.dist-info/METADATA
         789  2022-09-21 11:00   apache_airflow-2.5.0.dev0.dist-info/NOTICE
          92  2022-09-21 11:00   apache_airflow-2.5.0.dev0.dist-info/WHEEL
          50  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/entry_points.txt
           8  2022-09-21 11:00   
apache_airflow-2.5.0.dev0.dist-info/top_level.txt
       93366  2022-09-21 11:00   apache_airflow-2.5.0.dev0.dist-info/RECORD
   $  tar tf dist/apache-airflow-2.5.0.dev0.tar.gz 
apache-airflow-2.5.0.dev0/licenses/
   apache-airflow-2.5.0.dev0/licenses/
   apache-airflow-2.5.0.dev0/licenses/LICENSE-bootstrap.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-bootstrap3-typeahead.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-d3-shape.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-d3-tip.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-d3js.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-dagre-d3.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-datatables.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-elasticmock.txt
   
apache-airflow-2.5.0.dev0/licenses/LICENSE-eonasdan-bootstrap-datetimepicker.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-flask-kerberos.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-hue.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-jqclock.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-jquery.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-moment-strftime.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-moment.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSE-normalize.txt
   apache-airflow-2.5.0.dev0/licenses/LICENSES-ui.txt
   ```
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to