ashb commented on a change in pull request #5469: [AIRFLOW-4842] Add Py2 
deprecation notice
URL: https://github.com/apache/airflow/pull/5469#discussion_r296869549
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -98,7 +98,7 @@ sql_alchemy_pool_size = 5
 # additional connections will be returned up to this limit.
 # When those additional connections are returned to the pool, they are 
disconnected and discarded.
 # It follows then that the total number of simultaneous connections the pool 
will allow is pool_size + max_overflow,
-# and the total number of “sleeping” connections the pool will allow is 
pool_size.
+# and the total number of "sleeping" connections the pool will allow is 
pool_size.
 
 Review comment:
   It wasn't this (though I will fix that in #5471 - if someone would like to 
review that I can cherry-pick it in)
   
   It was `TERM` environment variable not being set, meaning :
   
   
   ```
     File "/usr/local/lib/python2.7/dist-packages/airflow/bin/cli.py", line 
2186, in should_color
       if "color" in os.environ.get("TERM"):
   TypeError: argument of type 'NoneType' is not iterable
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to