dstandish commented on code in PR #26376:
URL: https://github.com/apache/airflow/pull/26376#discussion_r978342158
##########
airflow/jobs/scheduler_job.py:
##########
@@ -1153,10 +1152,13 @@ def _create_dag_runs_dataset_triggered(
.all()
)
- data_interval =
dag.timetable.data_interval_for_events(exec_date, dataset_events)
+ data_interval = dag.timetable.data_interval_for_events(
+ last_event_timestamp, # type: ignore
+ dataset_events,
+ )
run_id = dag.timetable.generate_run_id(
run_type=DagRunType.DATASET_TRIGGERED,
- logical_date=exec_date,
+ logical_date=last_event_timestamp, # type: ignore
Review Comment:
it _thinks_ it wants DateTime
but, what we actually get when we read timestamp values from the database is
datetime
i think we've encountered this recently, and it was a bit of a rabbit hole
trying to fix it... but fundamentally i think that those timetable functions
that say DateTime are more often / more likely / maybe always getting datetime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
