potiuk commented on PR #25982: URL: https://github.com/apache/airflow/pull/25982#issuecomment-1255941168
> ository to the fork - I had some problems performing the squash via rebase. No worries - it takes time to master, but I am afraid you will have to rebase anyway if yoy want to get it merged. I think right now your commit needs to have conflicts resolved and we won't be able to merge it before you resolve the conflicts. > About the checks, I've been using the `pre-commit run --all-files` command to run the checks, not breeze - and I reran them and got the error. Not sure what happened yesterday - I may have forgotten to save the file before running the test. I've fixed it and I performed the pre-commit checks for all files again, everything seems to have passed. The `pre-comit run --all-files` is fine, but it will take a lot of time (10 minutes on my 16-core PC). It's much faster to run it locally on only changed files. You should run `pre-commit install` and then it will run all the checks only for files changed in your change (which is 100 times faster or so usually). You can also run it on sequence of commits `pre-commit run --from-ref HASH_COMMIT1 --to-ref HASH_COMMIT2` which will run pre-commit for all changed files between those two commits and breeze is merely adding few extra shortcuts so `--last-commit` is just shortcut to `--from-ref HEAD^ --to-ref HEAD` to only last commit. You can read more about it here: https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#using-pre-commit Following some of that, saves a lot of time. > Sorry about the amount of commits and the problems - but It's been quite a learning process. If this PR is too polluted, I can close it and open a new PR. No problem at all :). No need to do it . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
