akbarnotopb commented on PR #26669: URL: https://github.com/apache/airflow/pull/26669#issuecomment-1257653028
> > Can you add unit test? > > working on it I'm new to the community & this is my first PR ever made to open-source projects. I've read the unit test guidelines & existing unit test on `SqlToGTCSOperator` , but still, i just cannot think any idea on what should i add to the test regarding this case. Is comparing the filesize between parquet & csv enough? *there is already a test to make sure the data is valid, cmiiw It'll be helpful if you could give me rough idea/criteria that needs to be met in the test case? Thanks in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
