bhirsz commented on code in PR #26606:
URL: https://github.com/apache/airflow/pull/26606#discussion_r981022667


##########
tests/system/providers/amazon/aws/example_s3.py:
##########
@@ -202,6 +203,12 @@ def check_fn(files: list) -> bool:
     )
     # [END howto_operator_s3_file_transform]
 
+    # This task skips the `sensor_keys_unchanged` task because the 
S3KeysUnchangedSensor

Review Comment:
   ~~We overwrite the ``poke`` mode for the sensors (but not for all, I need to 
investigate the results..):~~
   Editing the comment - it appears the solution is not correct and it's 
failing with:
   ```
     File "/workspace/system_tests/airflow/airflow/sensors/base.py", line 276, 
in mode_setter
       raise ValueError("cannot set mode to 'poke'.")
   ValueError: cannot set mode to 'poke'.
   ```
   So the other option with the modified design is only option.
   
   Other option is to design the tests in a way, that if sensor is in 
reschedule mode it will not fail on first try (ie. if you're waiting for some 
file to appear, to upload the file first then run the sensor). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to