eladkal commented on code in PR #26374:
URL: https://github.com/apache/airflow/pull/26374#discussion_r981226123
##########
airflow/providers/slack/transfers/sql_to_slack.py:
##########
@@ -165,3 +193,115 @@ def execute(self, context: Context) -> None:
self._render_and_send_slack_message(context, df)
self.log.debug('Finished sending SQL data to Slack')
+
+
+class SqlToSlackApiFileOperator(BaseSqlToSlackOperator):
Review Comment:
I dont think we should add operator just to send file. I understand the
challange but I think we should try to mitigate this in the operator itself.
If Slack offers 3 diffrent approches than maybe we should have base class
and 3 operators one per approch? Then each operator will be able to levrage the
full capabilities of what slack offers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
