Jorricks commented on code in PR #26457:
URL: https://github.com/apache/airflow/pull/26457#discussion_r981322096
##########
airflow/www/static/js/dag/grid/dagRuns/Bar.tsx:
##########
@@ -110,7 +110,11 @@ const DagRunBar = ({
width="10px"
height={`${(duration / max) * BAR_HEIGHT}px`}
minHeight="14px"
- backgroundColor={stateColors[state]}
+ background={
+ run.notes != null && run.notes !== ''
+ ? `linear-gradient(-135deg,#000 8px, ${stateColors[state]} 0);`
Review Comment:
I think we should have a visual indication (as otherwise in a list of 100
TaskInstances, you'd never find the note).
Anyways, I think we can still tune it a bit. I don't have great designer
skills, but thought this looks reasonable and is very distinctive. We can also
change the color, figured black would just fit easily on top of all the bright
colors we have.
<img width="1338" alt="image"
src="https://user-images.githubusercontent.com/20257392/192553634-7ade2212-ae12-4b91-95d6-d761b0f8903c.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/20257392/192553634-7ade2212-ae12-4b91-95d6-d761b0f8903c.png"](https://user-images.githubusercontent.com/20257392/192553634-7ade2212-ae12-4b91-95d6-d761b0f8903c.png"){kind=link}