joshuayeung opened a new pull request, #26739:
URL: https://github.com/apache/airflow/pull/26739

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   This PR added IstioKubernetesPodOperator and IstioPodManager for making 
KubernetesPodOperator works in Kubernetes with Istio enabled.
   
   Istio will inject a sidecar called istio-proxy inside your pod and handle 
the traffic for you. But this hinders the standard workflow of the Kubernetes 
executor and Kubernetes Pod Operator. It is because both of them use the Pod 
Phase to determine the status of the dag task. Airflow will consider that the 
task is finished when the Pod Phase is successful and failed. Because of the 
istio-proxy sidecar, the pod will always be running. Just the task container 
itself is completed. This will lead to the Pod Phase become Not Ready in the 
success task, and Error in the failed task. In Airflow UI, you will see the 
task always running and never-ending.
   
   The best way is to implement an Istio Kubernetes Pod Operator that shut down 
the pod when the base container (the container that runs your task) is 
completed. It involves creating an Istio pod launcher.
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to