eladkal commented on code in PR #26746: URL: https://github.com/apache/airflow/pull/26746#discussion_r982324874
########## airflow/providers/slack/CHANGELOG.rst: ########## @@ -30,11 +30,10 @@ Changelog Breaking changes ~~~~~~~~~~~~~~~~ -* The hook class :class:`airflow.providers.slack.hooks.slack_webhook.SlackWebhookHook` not inherit from - :class:`airflow.providers.http.hooks.http.HttpHook` anymore. In practice the only impact on - user-defined classes based on **SlackWebhookHook** and you use attributes from **HttpHook**. -* Drop support deprecated ``webhook_token`` parameter in - :ref:`Slack Incoming Webhook Connection <howto/connection:slack-incoming-webhook>` Extra. +* The hook class ``SlackWebhookHook`` dies not inherit from ``HttpHook`` anymore. In practice the Review Comment: ```suggestion * The hook class ``SlackWebhookHook`` does not inherit from ``HttpHook`` anymore. In practice the ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
