[
https://issues.apache.org/jira/browse/AIRFLOW-4850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872436#comment-16872436
]
ASF GitHub Bot commented on AIRFLOW-4850:
-----------------------------------------
george-miller commented on pull request #5479: [AIRFLOW-4850] *_cmd
configuration options should interpolate environment variables
URL: https://github.com/apache/airflow/pull/5479
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4850
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
When specifying a configuration like sql_alchemy_conn_cmd, it should be able
to interpolate environment variables from the environment that airflow is
running from. This is really useful when you mount secrets as environment
variables and want to use them in this type of configuration option. For
example, this currently does not work:
`sql_alchemy_conn_cmd = echo
${POSTGRES_HOST}:${POSTGRES_PASSWORD}@postgres.com`
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Config _cmd options should interpolate environment variables
> ------------------------------------------------------------
>
> Key: AIRFLOW-4850
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4850
> Project: Apache Airflow
> Issue Type: New Feature
> Components: configuration
> Affects Versions: 1.10.4
> Reporter: George Miller
> Assignee: George Miller
> Priority: Major
>
> When specifying a configuration like sql_alchemy_conn_cmd, it should be able
> to interpolate environment variables from the environment that airflow is
> running from. This is really useful when you mount secrets as environment
> variables and want to use them in this type of configuration option. For
> example, this currently does not work:
>
> `sql_alchemy_conn_cmd = echo
> ${POSTGRES_HOST}:${[POSTGRES_PASSWORD}@postgres.com|mailto:[email protected]]`
>
> The change is really simple, and I opened a PR for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
