Jorricks commented on PR #26457:
URL: https://github.com/apache/airflow/pull/26457#issuecomment-1261876976

   > (This is a quick prototyping, needs to be fixed, borders, colors, marging 
etc.)
   
   I feel like this part of the UI is already filled with buttons and is quite 
'busy'. That's why I like the simple accordion without any colours/borders to 
be honest.
   
   
   > Also putting the note at the beginning could be interesting in the sense 
that you see it before running any action on the task/dagrun.
   
   Very much agreeing on that. I changed it. Now it looks like this;
   <img width="909" alt="Screenshot 2022-09-29 at 09 22 09" 
src="https://user-images.githubusercontent.com/20257392/192966859-d4f1b0cb-9556-4759-82d7-dc892df9fb38.png";>
   
   
   > I am thinking to the usecase where you start rerunning a task/marking it 
as failed, while someone already took action for this specific task, and 
documented it in the note. By having the note below you could miss that piece 
of information and trigger new task actions without noticing, overriding your 
colleague work.
   
   I think this sounds like a very nice idea! Also love the idea of the 
coloured button and maybe reporting there are notes for specific TaskInstances 
on the confirm page?
   However, I think this MR is already quite large and this would bring an 
extra level of complexity. 
   I would prefer to first cover the basics to create a user-friendly 
experience in this MR and then we improve upon this in the next MRs. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to