potiuk commented on issue #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#issuecomment-505622327 Hey @Fokko @ashb @gerardo @ashb @BasPH - I finally fixed all the issues and have a CI-green version (I believe) of the last "docker image" PR. I got the old Kubernetes scripts working (slightly improved them) and I think it is pretty much ready for final review. It works for my account build: https://travis-ci.org/potiuk/airflow/builds/550362466 but the build for apache are super-slow so I wait for the result on apache. I will work with @gerardo as a follow-up on docker-compose-enabled version of Kubernetes tests next so the improvements will continue, but for now I think it's past the time we start using benefits of the built-in image. The last version has a few fixes to the kubernetes build approach: * I adapted the scripts to root user inside the CI image * I use --no-deps switch in kubernetes compose so that there are no two copies of postgres/mysql and other images while the tests are running * I figured out a way how we can make sure latest versions of dependencies (within requirements from setup.py) are always installed for the tests * pylint/mypy/docs/flake are all using the docker images - so it is super-easy to reproduce the CI static code checks @BasPH - I also updated docs as part of my change. I am happy to merge it with your changes, or you can merge yours into mine - as you wish. Please review! I look forward to merging it finally!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
