dstandish commented on code in PR #26759: URL: https://github.com/apache/airflow/pull/26759#discussion_r984236609
########## docs/apache-airflow/production-deployment.rst: ########## @@ -222,6 +222,29 @@ you can exchange the Google Cloud Platform identity to the Amazon Web Service id which effectively means access to Amazon Web Service platform. For more information, see: :ref:`howto/connection:aws:gcp-federation` + +Applying patches from ``main`` +============================== + +On occasion, a user may want to apply a patch from ``main`` which has not yet made it into a release. Assuming you want to apply a specific PR to one of the official airflow images, you can apply roughly as follows. It's also possible to apply a specific commit. + +.. code-block:: docker Review Comment: @potiuk i think `publish` is a key word there. is providing instructions for applying a patch of your choosing the same thing as publishing unreleased materials? i'm not a lawyer; but i really don't think it's the same thing. that seems rather like saying that providing instructions for how to `pip install` a dependency is "publishing" a that external library. additionally, specific reference to main is problematic, we could rephrase to simply provide instructions for applying a PR or a commit, without specifying what branch that commit may be part of. it's not just patching unreleased code that is useful here; you might want to do your own backporting. ########## docs/apache-airflow/production-deployment.rst: ########## @@ -222,6 +222,29 @@ you can exchange the Google Cloud Platform identity to the Amazon Web Service id which effectively means access to Amazon Web Service platform. For more information, see: :ref:`howto/connection:aws:gcp-federation` + +Applying patches from ``main`` +============================== + +On occasion, a user may want to apply a patch from ``main`` which has not yet made it into a release. Assuming you want to apply a specific PR to one of the official airflow images, you can apply roughly as follows. It's also possible to apply a specific commit. + +.. code-block:: docker Review Comment: @potiuk i think `publish` is a key word there. is providing instructions for applying a patch of your choosing the same thing as publishing unreleased materials? i'm not a lawyer; but i really don't think it's the same thing. that seems rather like saying that providing instructions for how to `pip install` a dependency is "publishing" a that external library. additionally, if specific reference to main is problematic, we could rephrase to simply provide instructions for applying a PR or a commit, without specifying what branch that commit may be part of. it's not just patching unreleased code that is useful here; you might want to do your own backporting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
