XD-DENG commented on code in PR #26766:
URL: https://github.com/apache/airflow/pull/26766#discussion_r985117949
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -95,6 +95,9 @@ def get_connection_form_widgets() -> dict[str, Any]:
),
"extra__kubernetes__disable_verify_ssl":
BooleanField(lazy_gettext('Disable SSL')),
"extra__kubernetes__disable_tcp_keepalive":
BooleanField(lazy_gettext('Disable TCP keepalive')),
+ "extra__kubernetes__sidecar_container_image": StringField(
Review Comment:
I would like to suggest to make the name more explicit, like
`extra__kubernetes__xcom_sidecar_container_image`, since it's possible to add
other "sidecar" container(s) to the Pods.
Does this make sense to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
