potiuk commented on issue #26375: URL: https://github.com/apache/airflow/issues/26375#issuecomment-1264617538
> * Is [this](https://github.com/apache/airflow/blob/0da49935000476b1d1941b63d0d66d3c58d64fea/tests/api_connexion/test_error_handling.py) the right place to go about adding a test for this? I believe so. Also manual testing should be done. > * What is the expected behaviour for a 405 error? I'm guessing we want to use the `common_error_handler` function so it'll return a JSON response instead of a view Not really - I think we want to simply implement `view.method_not_allowed` method similar to `view.not_found` and split the `_handle_api_error` into two methods - `_handle_api_not_found` and `_handle_method_not_allowed` - decorated separate with errorhandler(404), errorhandler(405) respectively. That should do the job IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
