r-richmond commented on PR #26922:
URL: https://github.com/apache/airflow/pull/26922#issuecomment-1270684476
> and there is no need usually for you to run --all-files
👍 wasn't sure given the nature of the pr, ty for the info
> you do not need to use vscode/codespaces to run pre-commits ...
Pre-commits are supposed to be run locally.
100% correct. I just wanted to avoid installing all the airflow dependencies
locally (lots of them, multiple sub-dependencies mysql etc.) + the promise of
the pre-configured workspace via vs-code remote container dev was too shiny to
resist trying for this project.
I'm hoping I'll get dumb lucky and there are no other requirements for this
type of pr and it will pass tests if not I'm happy to let someone else take my
branch / pr over. & lastly
1) Do you see any issues with this modification in general given the points
I outlined above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
