bhirsz commented on code in PR #26915:
URL: https://github.com/apache/airflow/pull/26915#discussion_r989702419
##########
tests/system/providers/google/cloud/ml_engine/example_mlengine.py:
##########
@@ -216,28 +222,38 @@
# [END howto_operator_gcp_mlengine_get_prediction]
# [START howto_operator_gcp_mlengine_delete_version]
- delete_version = MLEngineDeleteVersionOperator(
- task_id="delete-version", project_id=PROJECT_ID,
model_name=MODEL_NAME, version_name="v1"
+ delete_version_v1 = MLEngineDeleteVersionOperator(
+ task_id="delete-version-v1",
+ project_id=PROJECT_ID,
+ model_name=MODEL_NAME,
+ version_name="v1",
+ trigger_rule=TriggerRule.ALL_DONE,
Review Comment:
keep trigger_rule out of doc example - as unnecessary addition:
# [START..
operator code..
# [END..
operator.trigger_rule = TriggerRule.ALL_DONE
##########
tests/system/providers/google/cloud/ml_engine/example_mlengine.py:
##########
@@ -216,28 +222,38 @@
# [END howto_operator_gcp_mlengine_get_prediction]
# [START howto_operator_gcp_mlengine_delete_version]
- delete_version = MLEngineDeleteVersionOperator(
- task_id="delete-version", project_id=PROJECT_ID,
model_name=MODEL_NAME, version_name="v1"
+ delete_version_v1 = MLEngineDeleteVersionOperator(
+ task_id="delete-version-v1",
+ project_id=PROJECT_ID,
+ model_name=MODEL_NAME,
+ version_name="v1",
+ trigger_rule=TriggerRule.ALL_DONE,
Review Comment:
keep trigger_rule out of doc example - as unnecessary addition:
```
# [START..
operator code..
# [END..
operator.trigger_rule = TriggerRule.ALL_DONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
