joseph-max-coalfire commented on code in PR #26945:
URL: https://github.com/apache/airflow/pull/26945#discussion_r991703610
##########
tests/charts/test_webserver.py:
##########
@@ -721,6 +721,30 @@ def test_should_add_component_specific_labels(self):
assert "test_label" in jmespath.search("metadata.labels", docs[0])
assert jmespath.search("metadata.labels", docs[0])["test_label"] ==
"test_label_value"
+ @parameterized.expand(
+ [
+ (
+ [{"name": "webserver-nodeport", "nodePort": "31000", "port":
"8080"}],
+ [{"name": "webserver-nodeport", "nodePort": 31000, "port":
8080}],
+ )
+ ]
+ )
+ def test_nodeport_service(self, ports, expected_ports):
Review Comment:
> looks like your params aren't consistent with those provided in expand
@dstandish Not sure I follow-- I used the test_ports_overrides param
structure as a reference, and [it looks like CI checks are
passing](https://github.com/apache/airflow/actions/runs/3222282528/jobs/5271598232)
> i'd also add an entry (in expand) for when no nodePort is provided
Added (lines 730-733) and tested locally with success. We'll see if the
remote CI checks pass as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
