davlum edited a comment on issue #5481: [AIRLFOW-4851] Refactor K8S codebase 
with k8s API models
URL: https://github.com/apache/airflow/pull/5481#issuecomment-505938555
 
 
   I'm also noticing that the `create_namespaced_pod` function of the 
kubernetes client (that we use in `run_pod` in the `PodLauncher` which calls 
the `KubernetesRequestFactory`) accepts a `V1Pod` object as an argument, which 
would mean we can skip this whole process of serialization from `object -> dict 
-> json/yaml`. Thoughts on this? I feel like there are significant amounts of 
code we can simplify.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to