o-nikolas commented on code in PR #27008:
URL: https://github.com/apache/airflow/pull/27008#discussion_r995110616


##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -593,7 +593,7 @@ def run_shell(verbose: bool, dry_run: bool, shell_params: 
ShellParams) -> RunCom
         get_console().print(f"[red]Error {command_result.returncode} 
returned[/]")
         if verbose:
             get_console().print(command_result.stderr)
-        return command_result
+        sys.exit(1)

Review Comment:
   I just missed this one, but for posterity: any reason to not pass along the 
exit code we receive from the command result instead of hardcoding it to `1`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to