bharanidharan14 commented on code in PR #27024:
URL: https://github.com/apache/airflow/pull/27024#discussion_r995710621
##########
airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -119,6 +150,17 @@ def __init__(
except ValueError:
logger.setLevel(logging.WARNING)
+ def _get_field(self, extra_dict, field_name):
+ prefix = 'extra__wasb__'
+ if field_name.startswith('extra_'):
+ raise ValueError(
+ f"Got prefixed name {field_name}; please remove the '{prefix}'
prefix "
+ f"when using this method."
+ )
+ if field_name in extra_dict:
+ return extra_dict[field_name] or None
+ return extra_dict.get(f"{prefix}{field_name}") or None
Review Comment:
we also write like this `extra_dict.get(f"{prefix}{field_name}", None)` ,
its upto you
##########
airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -119,6 +150,17 @@ def __init__(
except ValueError:
logger.setLevel(logging.WARNING)
+ def _get_field(self, extra_dict, field_name):
+ prefix = 'extra__wasb__'
+ if field_name.startswith('extra_'):
Review Comment:
Same as the previous PR review comment, can we check for the exact key
`extra__`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
