dstandish commented on code in PR #22253:
URL: https://github.com/apache/airflow/pull/22253#discussion_r997216242
##########
airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py:
##########
@@ -138,6 +139,39 @@ def convert_configmap(configmaps) -> k8s.V1EnvFromSource:
return
k8s.V1EnvFromSource(config_map_ref=k8s.V1ConfigMapEnvSource(name=configmaps))
+def convert_secret(secret) -> k8s.V1EnvFromSource:
Review Comment:
but do you need to convert anything at all? can't you just require the
object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
