hamedhsn commented on code in PR #22253:
URL: https://github.com/apache/airflow/pull/22253#discussion_r997986727
##########
airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py:
##########
@@ -138,6 +139,39 @@ def convert_configmap(configmaps) -> k8s.V1EnvFromSource:
return
k8s.V1EnvFromSource(config_map_ref=k8s.V1ConfigMapEnvSource(name=configmaps))
+def convert_secret(secret) -> k8s.V1EnvFromSource:
Review Comment:
yeah, we actually do by simplifying conversion between simple str or dict
into k8s objects definition.
e.g., user pass a simple secret name and this will turn into
k8s.V1EnvFromSource object to be passed to the crd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
