[GitHub] [airflow] michaelmicheal opened a new pull request, #27152: Sorting plugins customer menu links by category before name

[GitBox]

michaelmicheal opened a new pull request, #27152:
URL: https://github.com/apache/airflow/pull/27152

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   In developing custom menu links through plugins, we found that our dropdown 
menus weren't sorted alphabetically. Digging into it a bit, I found that the 
menu_links are sorted by name, so the category order is currently somewhat 
random. Sorting by category and then name keeps the order within a category 
sorted alphabetically, and sorts the categories alphabetically. Made this 
change as a patch to our deployments of 2.2.5 and it works great.
   Without change:
   <img width="844" alt="Screen Shot 2022-10-19 at 5 37 52 PM" 
src="https://user-images.githubusercontent.com/40223998/196809640-31f57369-a63d-4c10-b614-c62187653e45.png";>
   With change:
   <img width="702" alt="Screen Shot 2022-10-19 at 4 07 41 PM" 
src="https://user-images.githubusercontent.com/40223998/196809637-f119236c-21a8-49f6-8345-360a1e141c37.png";>
   
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org