vincbeck commented on code in PR #27070:
URL: https://github.com/apache/airflow/pull/27070#discussion_r1001030978


##########
airflow/providers/slack/hooks/slack_webhook.py:
##########
@@ -55,6 +55,34 @@ def wrapper(*args, **kwargs) -> Callable:
     return wrapper
 
 
+def _ensure_prefixes(conn_type):

Review Comment:
   I can see this function is a duplicate of the one defined in 
`airflow/providers/slack/hooks/slack.py` (and in many other PR you have open). 
Would not it be better to put it somewhere common once and then use it across 
the different providers?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to