potiuk commented on PR #27191: URL: https://github.com/apache/airflow/pull/27191#issuecomment-1287438806
Hello everyone. Still travelling back from holidays, but I figured I will push a few quick breeze/ci improvements on my way)/ This one (@ashb we discussed it) - removes the need of propagating "verbose" and "dry_run" parameters. Also it addresses the return code - fixed in #27008 by @ephraimbuddy and corrected in @27048 by @o-nikolas - a bit better. The sys.exit() was called a biit too early - in most other places sys.exit was called in "@click.command" function so that we can independently run and test underlying methods without actually running sys.exit() so I return the return_code and run sys.exit() command. While doing it I found that "run_shell" was only used in "enter_shell" so I merged those two methods as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
