mik-laj opened a new pull request, #27204:
URL: https://github.com/apache/airflow/pull/27204

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   I would like to run system tests for Snowflake on CI to make sure there is 
no regression, but unfortunately running these tests on Github Action was never 
successful.
   I took a look and ran into a few problems:
   * Missing `schedule="@once"` which means that the DAG were run every day in 
the range from `start_date` to `current_date`. I think `catchup = False` should 
fix that, but it doesn't. DAG Runes were still being created, which in effect 
meant that the DAGs never completed the expected time - <60 seconds.
   * I moved all the other operators to other files because I would like to 
focus only on `SnowflakeOperator` first. But as a next step, I would also like 
to fix the tests for `s3_to_snowflake` and `snowflake_to_slack`, but this is an 
extra effort.
   * I created a missing SQL file that was used by system tests. Unfortunately, 
this file cannot contain the license header, because Snowflake interprets the 
license header as a new SQL query, and we can only send one SQL query per 
request.  This is something that might be worth fixing, but for now, I'd like 
to run system tests without making any changes to the operator.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to