potiuk commented on PR #27034: URL: https://github.com/apache/airflow/pull/27034#issuecomment-1288149364
It's cool and it will remove a source of confusion for our users. First of all - you will need to rebase @RNHTTR - there are some conflicts. One general comment I have - the warning message mentions EnvironmentVariablesBackend but this one is not really part of custom secret backends so the use of it is not really detected. I thought we should really treat Environment variables a little differently than other custom secrets. As opposed to all other secrets we can actually check if any custom connection/variable is defined in Environment and print the warning when it is. We just have to check if there are anny AIRFLOW__CONNECTION__ env variables or AIRFLOW__VARIABLES__.* If you do it this way (additionally to checking if there is a custom backend defined), the warning will **also** be printed when there are any custom variables defined via env variables (and you can slightly modify the warning message to explain it). I think that would be a more comple solution to the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
