kaxil commented on a change in pull request #5408: [AIRFLOW-4763] Allow list in
DockerOperator.command
URL: https://github.com/apache/airflow/pull/5408#discussion_r298330758
##########
File path: airflow/operators/docker_operator.py
##########
@@ -247,7 +247,7 @@ def execute(self, context):
if self.xcom_all else line.encode('utf-8')
def get_command(self):
- if self.command is not None and self.command.strip().find('[') == 0:
+ if isinstance(self.command, str) and self.command.strip().find('[') ==
0:
Review comment:
Jinja would convert a list to list. `self.command.strip().find('[') == 0` is
checking a **string**, right? and checking if the first character is `[`.
Sorry, maybe I am missing something. @mik-laj Feel free to merge this PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
