mobuchowski commented on code in PR #27113:
URL: https://github.com/apache/airflow/pull/27113#discussion_r1004635203
##########
airflow/models/dagrun.py:
##########
@@ -580,11 +591,11 @@ def recalculate(self) -> _UnfinishedStates:
self.set_state(DagRunState.FAILED)
if execute_callbacks:
dag.handle_callback(self, success=False,
reason='task_failure', session=session)
- elif dag.has_on_failure_callback:
+ elif dag.has_on_failure_callback or notification:
from airflow.models.dag import DagModel
dag_model = DagModel.get_dagmodel(dag.dag_id, session)
- callback = DagCallbackRequest(
+ cb = DagCallbackRequest(
Review Comment:
Reverted that part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
