uranusjr commented on code in PR #27145:
URL: https://github.com/apache/airflow/pull/27145#discussion_r1005297516
##########
airflow/models/dag.py:
##########
@@ -451,6 +453,7 @@ def __init__(
max_active_tasks = concurrency
self._max_active_tasks = max_active_tasks
self._pickle_id: int | None = None
+ self._display_name = dag_id if display_name is None else display_name
Review Comment:
This would allow the user to pass in an empty display name, which would look
pretty terrible anywhere. I’d make the argument `display_name: str = ""`
instead and do `self._display_name = display_name or dag_id` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
