pankajastro commented on code in PR #27276:
URL: https://github.com/apache/airflow/pull/27276#discussion_r1005941984
##########
airflow/providers/amazon/aws/hooks/redshift_cluster.py:
##########
@@ -166,7 +166,6 @@ def get_cluster_snapshot_status(self, snapshot_identifier:
str, cluster_identifi
"""
try:
response = self.get_conn().describe_cluster_snapshots(
Review Comment:
why this change, I think the purpose of this hook method is to get the
snapshot of a cluster WDYT?
##########
airflow/providers/amazon/aws/hooks/redshift_cluster.py:
##########
@@ -157,7 +157,7 @@ def create_cluster_snapshot(
)
return response["Snapshot"] if response["Snapshot"] else None
- def get_cluster_snapshot_status(self, snapshot_identifier: str,
cluster_identifier: str):
+ def get_cluster_snapshot_status(self, snapshot_identifier: str):
Review Comment:
I feel changing definition of a hook method is a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
