potiuk commented on code in PR #27264:
URL: https://github.com/apache/airflow/pull/27264#discussion_r1008032606


##########
Dockerfile:
##########
@@ -1215,7 +1215,7 @@ ARG ADDITIONAL_PYTHON_DEPS=""
 # are compatible with the new protobuf version. All the google python client 
libraries need
 # to be upgraded to >=2.0.0 in order to able to lift that limitation
 # 
https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates
-ARG EAGER_UPGRADE_ADDITIONAL_REQUIREMENTS="dill<0.3.3 pyarrow>=6.0.0 
protobuf<4.21.0"
+ARG EAGER_UPGRADE_ADDITIONAL_REQUIREMENTS="dill<0.3.3 
pyarrow>=6.0.0;python_version==\"3.10\" protobuf<4.21.0"

Review Comment:
   BTW. Just while explaining it, I realised that we can do it differently (and 
less "magically"). We could actually add pyarrow > 6.0.0 to all the extras that 
use it. That might be a better solution from user point of view but then we 
will have to basically copy&paste `pyarrow>=6.0.0` to all the provider.yaml 
files of providers that have it as dependency.
   
   Maybe that is a better solution- WDYT @uranusjr ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to