sachebotarev commented on PR #25714: URL: https://github.com/apache/airflow/pull/25714#issuecomment-1295754000
Hi @pateash I'm interested in having airflow support ClickHouse, but I don't want to have such a standard implementation. 1. You just copied Anton Bryzgalov's rather old code https://github.com/bryzgaloff/airflow-clickhouse-plugin It seems to me that Anton's approach is outdated 2. clickhouse-driver supports DB API 2.0 so inheriting from DbApiHook and ClickHouseOperator will provide many out of the box solutions. insert_rows( ) can be overridden with Cursor.executemany or just rise exception. 4. ClickHouseHook provides very limited comparison functionality, for example with ExasolHook (also an analytical database) 4. ClickHouseOperator does not provide the same capabilities as operators inherited from the modern SQLExecuteQueryOperator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
