potiuk commented on code in PR #27357: URL: https://github.com/apache/airflow/pull/27357#discussion_r1008696430
########## chart/Chart.lock: ########## @@ -1,5 +1,6 @@ dependencies: - name: postgresql - version: 10.5.3 -digest: sha256:7104938113e866364a96f78802697be6bd121526cccbd06cae6a38827b7b36f9 -generated: "2022-06-11T22:19:11.389661+02:00" + repository: https://charts.bitnami.com/bitnami + version: 12.0.0 +digest: sha256:7de3ef06bed45277fef19fe8290f08d0b744c12aeb34eee9babf1e9d1a429cb2 Review Comment: Do I understand it correctly that we do not HAVE TO update to get it works (I see that the binary .tgz is replaced not removed) If so - this is really cool. We had it initially done like that but that caused unnecessary dependency on the external chart which is a bad idea in some scenarios - for example when user instals the charts behind firewalls from local sources. It also introduced instability in our CI process. So we decided to embed the .tgz (see https://github.com/apache/airflow/issues/24037 and PR #24395) However - if I understand correctly - this one is purely to make it easier in the future if we want to upgrade (or it makes it easy for users to upgrade if they want to them themselves? This does not introduce "necessity" of running `helm update` correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
