potiuk opened a new pull request, #27366: URL: https://github.com/apache/airflow/pull/27366
The #27191 change introduced globally shareable flags for verbose and dry-run flags in Breeze however it also changed behaviour of the "false" string passed by VERBOSE/DRY_RUN env variables and crashed breeze when one of those variables was set to empty string. As a result CI's "VERBOSE" "false" flag in static checks was treated as "truthy" and static checks output contained a lot of noise from non-failing static checks. It turns out that "convert" method of click can also take "strings" as parameter because coertion of env variables happens inside the convert method (which mkes sense if you think about it) so the convert method should accept both string and target type values, This is explained in convert method docs but I missed it :(. This change fixes both problems by introducing explicit coertion of the variables from all kinds of string values - both when the flags are parsed but also before (sometimes we need verbose flag from variable (when we run breeze in scripts) even before the flag is actually parsed by click so additionally to coercing the flag, we also pre-emptively run the same coertion when importing the "shared_options" module. Also just for the sake of it, we accept all kinds of truth-y, falsy strings now - true/false/yes/no/t/f/y/n in all kinds of casing and shortcuts. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
