bdsoha commented on code in PR #26970: URL: https://github.com/apache/airflow/pull/26970#discussion_r1008877401
########## tests/providers/apache/impala/hooks/test_impala.py: ########## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import unittest +from unittest import mock +from unittest.mock import patch + +from airflow.models import Connection +from airflow.providers.apache.impala.hooks.impala import ImpalaHook + + +class TestImpalaHookConn(unittest.TestCase): + def setUp(self): + super().setUp() + self.connection = Connection( + login='login', + password='password', + host='host', + port=21050, + schema='test', + ) + + class UnitTestImapalHook(ImpalaHook): + conn_name_attr = 'impala_conn_id' Review Comment: Replace quotes: ```python class TestImpalaHookConn(unittest.TestCase): def setUp(self): super().setUp() self.connection = Connection( login="login", password="password", host="host", port=21050, schema="test", ) class UnitTestImapalHook(ImpalaHook): conn_name_attr = "impala_conn_id" ``` ########## airflow/providers/apache/impala/hooks/impala.py: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from impala.dbapi import connect +from impala.interface import Connection + +from airflow.hooks.dbapi import DbApiHook + + +class ImpalaHook(DbApiHook): + """Interact with Apache Impala through impyla.""" + + conn_name_attr = 'impala_conn_id' + default_conn_name = 'impala_default' + conn_type = 'impala' + hook_name = "Impala" Review Comment: You should replace all quotes with double-quotes in order to pass static checks. ```python class ImpalaHook(DbApiHook): """Interact with Apache Impala through impyla.""" conn_name_attr = "impala_conn_id" default_conn_name = "impala_default" conn_type = "impala" hook_name = "Impala" ``` ########## tests/providers/apache/impala/hooks/test_impala.py: ########## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import unittest +from unittest import mock +from unittest.mock import patch + +from airflow.models import Connection +from airflow.providers.apache.impala.hooks.impala import ImpalaHook + + +class TestImpalaHookConn(unittest.TestCase): + def setUp(self): + super().setUp() + self.connection = Connection( + login='login', + password='password', + host='host', + port=21050, + schema='test', + ) + + class UnitTestImapalHook(ImpalaHook): + conn_name_attr = 'impala_conn_id' + + self.db_hook = UnitTestImapalHook() + self.db_hook.get_connection = mock.Mock() + self.db_hook.get_connection.return_value = self.connection + + @patch("airflow.providers.apache.impala.hooks.impala.connect") + def test_get_conn(self, mock_connect): + self.db_hook.get_conn() + mock_connect.assert_called_once_with( + host="host", port=21050, user="login", password="password", database="test" + ) + + +class TestImpalaHook(unittest.TestCase): + def setUp(self): + super().setUp() + + self.cur = mock.MagicMock() + self.conn = mock.MagicMock() + self.conn.cursor.return_value = self.cur + conn = self.conn + + class UnitTestImpalaHook(ImpalaHook): + conn_name_attr = 'test_conn_id' + + def get_conn(self): + return conn + + self.db_hook = UnitTestImpalaHook() + + @patch('airflow.hooks.dbapi_hook.DbApiHook.insert_rows') + def test_insert_rows(self, mock_insert_rows): + table = "table" + rows = [("hello",), ("world",)] + target_fields = None + commit_every = 10 + self.db_hook.insert_rows(table, rows, target_fields, commit_every) + mock_insert_rows.assert_called_once_with(table, rows, None, 10) + + def test_get_first_record(self): + statement = 'SQL' + result_sets = [('row1',), ('row2',)] + self.cur.fetchone.return_value = result_sets[0] + + self.assertEqual(result_sets[0], self.db_hook.get_first(statement)) + self.conn.close.assert_called_once_with() + self.cur.close.assert_called_once_with() + self.cur.execute.assert_called_once_with(statement) + + def test_get_records(self): + statement = 'SQL' + result_sets = [('row1',), ('row2',)] + self.cur.fetchall.return_value = result_sets + + self.assertEqual(result_sets, self.db_hook.get_records(statement)) + self.conn.close.assert_called_once_with() + self.cur.close.assert_called_once_with() + self.cur.execute.assert_called_once_with(statement) + + def test_get_pandas_df(self): + statement = 'SQL' + column = 'col' + result_sets = [('row1',), ('row2',)] + self.cur.description = [(column,)] + self.cur.fetchall.return_value = result_sets + df = self.db_hook.get_pandas_df(statement) Review Comment: Replace quotes: ```python def test_get_first_record(self): statement = "SQL" result_sets = [("row1",), ("row2",)] self.cur.fetchone.return_value = result_sets[0] self.assertEqual(result_sets[0], self.db_hook.get_first(statement)) self.conn.close.assert_called_once_with() self.cur.close.assert_called_once_with() self.cur.execute.assert_called_once_with(statement) def test_get_records(self): statement = "SQL" result_sets = [("row1",), ("row2",)] self.cur.fetchall.return_value = result_sets self.assertEqual(result_sets, self.db_hook.get_records(statement)) self.conn.close.assert_called_once_with() self.cur.close.assert_called_once_with() self.cur.execute.assert_called_once_with(statement) def test_get_pandas_df(self): statement = "SQL" column = "col" result_sets = [("row1",), ("row2",)] self.cur.description = [(column,)] self.cur.fetchall.return_value = result_sets df = self.db_hook.get_pandas_df(statement) ``` ########## tests/providers/apache/impala/hooks/test_impala.py: ########## @@ -0,0 +1,110 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import unittest +from unittest import mock +from unittest.mock import patch + +from airflow.models import Connection +from airflow.providers.apache.impala.hooks.impala import ImpalaHook + + +class TestImpalaHookConn(unittest.TestCase): + def setUp(self): + super().setUp() + self.connection = Connection( + login='login', + password='password', + host='host', + port=21050, + schema='test', + ) + + class UnitTestImapalHook(ImpalaHook): + conn_name_attr = 'impala_conn_id' + + self.db_hook = UnitTestImapalHook() + self.db_hook.get_connection = mock.Mock() + self.db_hook.get_connection.return_value = self.connection + + @patch("airflow.providers.apache.impala.hooks.impala.connect") + def test_get_conn(self, mock_connect): + self.db_hook.get_conn() + mock_connect.assert_called_once_with( + host="host", port=21050, user="login", password="password", database="test" + ) + + +class TestImpalaHook(unittest.TestCase): + def setUp(self): + super().setUp() + + self.cur = mock.MagicMock() + self.conn = mock.MagicMock() + self.conn.cursor.return_value = self.cur + conn = self.conn + + class UnitTestImpalaHook(ImpalaHook): + conn_name_attr = 'test_conn_id' + + def get_conn(self): + return conn + + self.db_hook = UnitTestImpalaHook() + + @patch('airflow.hooks.dbapi_hook.DbApiHook.insert_rows') + def test_insert_rows(self, mock_insert_rows): Review Comment: Replace quotes: ```python class UnitTestImpalaHook(ImpalaHook): conn_name_attr = "test_conn_id" def get_conn(self): return conn self.db_hook = UnitTestImpalaHook() @patch("airflow.hooks.dbapi_hook.DbApiHook.insert_rows") def test_insert_rows(self, mock_insert_rows): ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
