hankehly commented on code in PR #27410:
URL: https://github.com/apache/airflow/pull/27410#discussion_r1009685212
##########
tests/providers/amazon/aws/operators/test_rds.py:
##########
@@ -227,7 +208,7 @@ def test_create_db_instance_snapshot_no_wait(self,
mock_await_status):
assert instance_snapshots
assert len(instance_snapshots) == 1
- assert mock_await_status.not_called()
+ mock_wait.assert_not_called()
Review Comment:
`not_called` is not a method. `mock_await_status` is a mock, so the call
does not raise an error, but it does not check the intended condition. Replaced
with
[`assert_not_called`](https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_not_called)
here and below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
