eladkal commented on code in PR #27319:
URL: https://github.com/apache/airflow/pull/27319#discussion_r1010914530
##########
airflow/providers/oracle/operators/oracle.py:
##########
@@ -93,4 +94,10 @@ def __init__(
def execute(self, context: Context):
self.log.info("Executing: %s", self.procedure)
hook = OracleHook(oracle_conn_id=self.oracle_conn_id)
- return hook.callproc(self.procedure, autocommit=True,
parameters=self.parameters)
+ ti=context.get('task_instance')
+ try:
+ return hook.callproc(self.procedure, autocommit=True,
parameters=self.parameters)
+ except oracledb.DatabaseError as e:
+ code, mesg = e.args[0].message[:-1].split(': ', 1)
+ ti.xcom_push(key='ORA', value=str(code.split('-')[1]))
Review Comment:
Consider that not all users need this functionality. Why should we "spam"
thier xcom table with data that has no value for them?
The use case of doing something in downstream task with error code of
upstream task is not that common. at least from reviewing our issue tracker and
questions on slack/other platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
