uranusjr commented on code in PR #27442:
URL: https://github.com/apache/airflow/pull/27442#discussion_r1011338364
##########
airflow/providers/ssh/hooks/ssh.py:
##########
@@ -494,11 +494,13 @@ def exec_ssh_client_command(
if recv.recv_ready():
line = stdout.channel.recv(len(recv.in_buffer))
agg_stdout += line
- self.log.info(line.decode("utf-8", "replace").strip("\n"))
+ for line in line.decode("utf-8",
"replace").strip("\n").splitlines():
+ self.log.info(line)
Review Comment:
```suggestion
self.log.info("%s", line)
```
I think this is better for custom formatters. The default formatter just
prepend things so there’s no differences, but having the variable separate with
the format can have a difference in e.g. secret masking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
