calebwoofenden commented on code in PR #27357: URL: https://github.com/apache/airflow/pull/27357#discussion_r1012988012
########## chart/templates/NOTES.txt: ########## @@ -187,3 +187,9 @@ Information on how to set a static webserver secret key can be found here: https://airflow.apache.org/docs/helm-chart/stable/production-guide.html#webserver-secret-key {{- end }} + +{{- if or .Values.postgresql.postgresqlUsername .Values.postgresql.postgresqlPassword }} + + {{ fail "postgresql.postgresqlUsername and postgresql.postgresqlPassword have been renamed to postgresql.auth.username and postgres.auth.password }} Review Comment: Ah, good catch. Fixed the missing end quote. I just tested locally by running this command from the root of the repo: ``` helm install --debug --dry-run airflow ./chart --set-string postgresql.postgresqlPassword=blah ``` and same with `postgresql.postgresqlUsername` and it failed as expected in both situations. It succeeded without the `--set-string`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
