zhiyong-ong opened a new pull request, #27501:
URL: https://github.com/apache/airflow/pull/27501

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: https://github.com/apache/airflow/issues/27462
   related: https://github.com/apache/airflow/issues/27462
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   This fixes the bug where clearing a parent dag will not clear the child 
dag's mapped task.
   
   The bug was due to `TaskInstanceKey` accepting its attributes in the order 
(dag_id, task_id, run_id, try_number, map_index) while in 
`_get_task_instances`, the `pk_tuple` that we pass into `TaskInstanceKey` to 
get the `result` is (dag_id, task_id, run_id, map_index), missing out the 
try_number. So `TaskInstanceKey` assumes that the map_index value supplied is 
try_number and defaults the value of map_index to -1. This causes a bunch of 
problems downstream when we try and retrieve the `TaskInstance` from the table 
using the map_index as part of the filter. 
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to