eladkal commented on code in PR #27514:
URL: https://github.com/apache/airflow/pull/27514#discussion_r1014629024
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -294,6 +297,22 @@ def _run_command(self, cur, sql_statement, parameters):
if cur.rowcount >= 0:
self.log.info("Rows affected: %s", cur.rowcount)
+ def _update_query_ids(self, cursor) -> None:
+ """
+ Adds query ids to list
+ :param cur: current cursor after run
+ :return:
+ """
+ return None
+
+ def stop_query(self, query_id) -> Any:
Review Comment:
I don't really mind about specific name just about
consistency/standartization.
There are places in the projects where names were just given without too
much thought so I'm raising it whenever I can and whenever appropriate.
It's OK also to decide to keep as is.
In any case - naming while important are not the priority. We can leave that
point after functionality works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
