rajat-tomar commented on code in PR #27480:
URL: https://github.com/apache/airflow/pull/27480#discussion_r1015002781
##########
chart/values.yaml:
##########
@@ -1695,7 +1695,7 @@ config:
# For Airflow 1.10
rbac: 'True'
celery:
- flower_url_prefix: '{{ .Values.ingress.flower.path }}'
+ flower_url_prefix: ''
Review Comment:
We're making url_prefix default to "" because if we take `{{
.Values.ingress.flower.path }` it adds a '/' in front of the script paths to
load as mentioned in the issue, which comes from the value of `{{
.Values.ingress.flower.path }}`. which in turn doesn't add localhost to
requests in browser and try to make direct requests to static assets. so it
gives 404.
Making it "" removes that extra '/' and the path works correct.
##########
chart/values.yaml:
##########
@@ -1695,7 +1695,7 @@ config:
# For Airflow 1.10
rbac: 'True'
celery:
- flower_url_prefix: '{{ .Values.ingress.flower.path }}'
+ flower_url_prefix: ''
Review Comment:
We're making url_prefix default to "" because if we take `{{
.Values.ingress.flower.path }}` it adds a '/' in front of the script paths to
load as mentioned in the issue, which comes from the value of `{{
.Values.ingress.flower.path }}`. which in turn doesn't add localhost to
requests in browser and try to make direct requests to static assets. so it
gives 404.
Making it "" removes that extra '/' and the path works correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
