Doncode commented on a change in pull request #5503: [AIRFLOW-3360] Make the
DAGs search respect other querystring parameters
URL: https://github.com/apache/airflow/pull/5503#discussion_r298838053
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -218,8 +218,9 @@ <h2>DAGs</h2>
$('#dag_query').on('keypress', function (e) {
// check for key press on ENTER (key code 13) to trigger the search
if (e.which === ENTER_KEY_CODE) {
- search_query = $('#dag_query').val();
- window.location = DAGS_INDEX + "?search="+ encodeURI(search_query);
+ var query = new URLSearchParams(window.location.search);
Review comment:
@ashb I checked the web interface in IE 11 before the changes and it did not
work.
JS code has a syntax error (IE11) in other parts. [=> and \` ]
I added `url-search-params-polyfill` in separeted bransh
[AIRFLOW-3360-polyfill](https://github.com/Doncode/airflow/tree/feature/AIRFLOW-3360-polyfill)
Should i add it to PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
